Skip to content

Make sure fast grid scan paramters are applied #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Make sure fast grid scan paramters are applied #1689

wants to merge 8 commits into from

Conversation

@DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Oct 31, 2025 •
edited
Loading

Part of DiamondLightSource/mx-bluesky#1360

The fast grid scan parameters get rounded on the readback value so we need to check that they get set with a tolerance. The test needs bluesky/ophyd-async#1096 so you will have to update your local ophyd-async to test

Instructions to reviewer on how to test:

  1. Confirm tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DominicOram DominicOram changed the title Mx bluesky 1360 fast gridscan not applied Make sure fast grid scan paramters are applied Oct 31, 2025
@DominicOram DominicOram mentioned this pull request Oct 31, 2025
Open
1 task
@DominicOram DominicOram marked this pull request as ready for review November 4, 2025 10:47
@DominicOram DominicOram requested a review from a team as a code owner November 4, 2025 10:47
@DominicOram
Copy link
Contributor Author

DominicOram commented Nov 4, 2025

Tests fixed in #1693

@codecov
Copy link

codecov bot commented Nov 6, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.91%. Comparing base (fae6079) to head (bdb43da).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1689   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         271      271           
  Lines        9919     9923    +4     
=======================================
+ Hits         9811     9815    +4     
  Misses        108      108

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DominicOram